This repository was archived by the owner on May 12, 2025. It is now read-only.
Conversation
ferranbt
previously approved these changes
Dec 13, 2023
Member
Author
|
yeah it's the same whoops, I left a comment over there. I dont think we need to specify the curve in the precompile name |
* err on suave precompile is type ErrExecutionReverted * restrict go version to 1.21.1
* Add PeekerReverted error to Suave abi * Commit real one
* Add precompile to make remote http calls * Fix error * Handle error and integrate other external calls * Last fixes * Fix * Show more diffs * Fix test
* bid -> dataRecord * working renames * change FetchBid to FetchRecord * update vm contracts * update devenv mevshare script * the last references of bid * the LAST improper bid reference * Add format to Solidity --------- Co-authored-by: Ferran Borreguero <ferran.borreguero@gmail.com>
* Add console log support * Fix lint
ferranbt
reviewed
Dec 22, 2023
| return records, nil | ||
| } | ||
|
|
||
| func (s *suaveRuntime) signMessage(digest []byte, signingKey string) ([]byte, error) { |
Contributor
There was a problem hiding this comment.
Why is signingKey not bytes as well?
Member
Author
There was a problem hiding this comment.
the signingKey in our other precompiles are also strings. Im not entirely sure why we set this precedent but I believe it was @Ruteri who did
Member
Author
There was a problem hiding this comment.
ferranbt
approved these changes
Dec 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
adds precompile to sign arbitrary digests using ECDSA signing key.
Note: I added this precompile to
contracts_suave.gosince it is not ethereum specific.📚 References
SUAVE-spec PR