Skip to content
This repository was archived by the owner on May 12, 2025. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions miner/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,28 +131,28 @@ func (b *Builder) addBundle(bundle *suavextypes.Bundle, env *environment) (*suav
revertingHashes := bundle.RevertingHashesMap()
egp := uint64(0)

var results []*suavextypes.SimulateTransactionResult
var logs []*suavextypes.SimulatedLog
for _, txn := range bundle.Txs {
result, err := b.addTransaction(txn, env)
results = append(results, result)
logs = append(logs, result.Logs...)
if err != nil {
if _, ok := revertingHashes[txn.Hash()]; ok {
// continue if the transaction is in the reverting hashes
continue
}
return &suavextypes.SimulateBundleResult{
Error: err.Error(),
SimulateTransactionResults: results,
Success: false,
Error: err.Error(),
Logs: logs,
Success: false,
}, err
}
egp += result.Egp
}

return &suavextypes.SimulateBundleResult{
Egp: egp,
SimulateTransactionResults: results,
Success: true,
Egp: egp,
Logs: logs,
Success: true,
}, nil
}

Expand Down
14 changes: 5 additions & 9 deletions miner/builder_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,7 @@ func TestBuilder_AddBundles_RevertHashes(t *testing.T) {
require.NoError(t, err)
require.Len(t, res, 1)
require.False(t, res[0].Success)
require.Len(t, res[0].SimulateTransactionResults, 2)
require.True(t, res[0].SimulateTransactionResults[0].Success)
require.False(t, res[0].SimulateTransactionResults[1].Success)
require.Len(t, res[0].Logs, 0)
require.Equal(t, big.NewInt(0), builder.env.state.GetBalance(testUserAddress))

bundle.RevertingHashes = []common.Hash{tx2.Hash()}
Expand All @@ -130,9 +128,7 @@ func TestBuilder_AddBundles_RevertHashes(t *testing.T) {
require.NoError(t, err)
require.Len(t, res, 1)
require.True(t, res[0].Success)
require.Len(t, res[0].SimulateTransactionResults, 2)
require.True(t, res[0].SimulateTransactionResults[0].Success)
require.False(t, res[0].SimulateTransactionResults[1].Success)
require.Len(t, res[0].Logs, 0)
require.Equal(t, big.NewInt(1000), builder.env.state.GetBalance(testUserAddress))
}

Expand All @@ -159,7 +155,7 @@ func TestBuilder_AddBundles_InvalidParams(t *testing.T) {
require.Len(t, res, 1)
require.False(t, res[0].Success)
require.Equal(t, ErrInvalidBlockNumber.Error(), res[0].Error)
require.Len(t, res[0].SimulateTransactionResults, 0)
require.Len(t, res[0].Logs, 0)
require.Equal(t, big.NewInt(0), builder.env.state.GetBalance(testUserAddress))

bundle = &suavextypes.Bundle{
Expand All @@ -173,7 +169,7 @@ func TestBuilder_AddBundles_InvalidParams(t *testing.T) {
require.Len(t, res, 1)
require.False(t, res[0].Success)
require.Equal(t, ErrExceedsMaxBlock.Error(), res[0].Error)
require.Len(t, res[0].SimulateTransactionResults, 0)
require.Len(t, res[0].Logs, 0)
require.Equal(t, big.NewInt(0), builder.env.state.GetBalance(testUserAddress))

bundle = &suavextypes.Bundle{
Expand All @@ -184,7 +180,7 @@ func TestBuilder_AddBundles_InvalidParams(t *testing.T) {
require.NoError(t, err)
require.False(t, res[0].Success)
require.Equal(t, ErrEmptyTxs.Error(), res[0].Error)
require.Len(t, res[0].SimulateTransactionResults, 0)
require.Len(t, res[0].Logs, 0)
require.Equal(t, big.NewInt(0), builder.env.state.GetBalance(testUserAddress))
}

Expand Down
8 changes: 4 additions & 4 deletions suave/builder/api/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ type SimulateTransactionResult struct {
}

type SimulateBundleResult struct {
Egp uint64 `json:"egp"`
SimulateTransactionResults []*SimulateTransactionResult `json:"simulateTransactionResults"`
Success bool `json:"success"`
Error string `json:"error"`
Egp uint64 `json:"egp"`
Logs []*SimulatedLog `json:"logs"`
Success bool `json:"success"`
Error string `json:"error"`
}

// field type overrides for gencodec
Expand Down