feat: added metrics for "url" in query params #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
force-pushed
the
feat/add-url-param-usage
branch
2 times, most recently
from
a384cf8 to
8f54c2a
Compare
shanejonas
commented
Sep 5, 2025
shanejonas
force-pushed
the
feat/add-url-param-usage
branch
from
8f54c2a to
9b073b6
Compare
shanejonas
commented
Sep 8, 2025
| statusBadRequest = metrics.NewCounter(`http_requests_total{status="400"}`) | ||
| statusNotFound = metrics.NewCounter(`http_requests_total{status="404"}`) | ||
| statusInternalServerError = metrics.NewCounter(`http_requests_total{status="500"}`) | ||
| UrlParamUsage = metrics.NewCounter(`http_requests_params{name="url"}`) |
Collaborator
Author
There was a problem hiding this comment.
exposed publicly for the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This adds metrics for the
urlparam proxying to a different upstream provider than the default.It does expose one of the metric vars publicly to test:
UrlParamUsage. There isn't any other metrics tests so its the only one exposed.⛱ Motivation and Context
Usage of this feature will dictate to keep or deprecate.
📷 Screenshots
✅ I have run these commands
make lintmake testgo mod tidy