feat: Add setLength() to DistanceJoint#104
Conversation
spydon
left a comment
There was a problem hiding this comment.
The field doesn't have to be private if the setter doesn't have to do anything else, but aren't other values affected by you changing the length? I'm guessing it also shouldn't be possible to do this meanwhile the world is locked, or it would probably have some strange side effects.
Have you tried it?
Sorry, I don’t have the ability to fully test these features, and I don’t really understand the concepts you mentioned. I think it’s best for me to close this PR for now. Hopefully this functionality can be supported in a future release. |
Description
This PR adds a missing API to
DistanceJoint:setLength(double newLength)to dynamically update the joint’s target length during simulation.lengthto expose the current target length.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues