Only return 'normal' as the range when no value is given. #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #178
parseAnimationRangewas changed to use string values of"normal"instead of objects representing the normal range. This essentially broke the parsing ofanimation-range, as later on that function tries to update values in that (now inexistent) object.On the console, these errors could be seen, as reported in #183:
This PR fixes this: return the default
"normal"when no value is given, but continue with the objects when there is a value to parse.Note that this is only for parsing ranges of
ViewTimelimeinstances. ForScrollTimeline, more work needs to be done in #153.PS: I didn’t get to updating the test results as I’ve got issues launching them with firefox for some reason. Safari works fine, but gives totally different base results.