Open
Conversation
Contributor
Author
|
The permission thing might be the most controversial contribution, because i don't really know whether there's any benefit. More explicitly:
So However, as long as the app stays clear of the Play Store, keeping the mere option to request "All files access" doesn't hurt either, so i opted for keeping it in the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings back support for (finding) files on external storage on Android 11 and later.
(Disclaimer: i'm more of an Android dabbler and though i tried my best at reading up on stuff as necessary, it is entirely possible that i missed something important.)
The commit names should be pretty self explanatory, and you can see all of the new features in the following
Android 15 (emulator) screen recording.
external-storage.mp4
(Not terribly important, but in the video,
emulated/0was listed as a single item under/storage. That differs from the current PR's version, where it is properly split intoemulatedfollowed by0.)In principle, the commits for the initial path preference are orthogonal to the /storage discovery commit. And both of the latter seem to be orthogonal to the
MANAGE_EXTERNAL_STORAGEpermission.From a user's perspective, the changes should be entirely backwards compatible.
(My Android Studio needed to upgrade its gradle plugin or whatever, which is mostly Android development black magic to me, but i suspect the corresponding changes to tracked files should not be included in this PR ...(?))
Should fix #111.