fix: avoid deleting files in setup.py#243
Closed
RFCreate wants to merge 1 commit intoflacjacket:mainfrom
Closed
Conversation
Contributor
Author
|
@flacjacket can you review this pls |
Owner
|
@RFCreate is there a reason you closed this PR? (Sorry for the slow review!) |
Contributor
Author
|
Don't worry, I put everything in one PR #244 to make things quicker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I learned this from developing in pywayland, this should be better than the patch I introduce to remove created files in
setup.py.