Generate dynamic protocol headers#239
Merged
flacjacket merged 7 commits intoflacjacket:mainfrom Sep 17, 2025
Merged
Conversation
RFCreate
force-pushed
the
dynamic-headers
branch
from
ca3e865 to
3b4319a
Compare
RFCreate
force-pushed
the
dynamic-headers
branch
2 times, most recently
from
27ab854 to
14b1c4f
Compare
flacjacket
requested changes
Sep 14, 2025
Owner
flacjacket
left a comment
flacjacket
left a comment
There was a problem hiding this comment.
This is a great idea! Just one note on the xkbcommon version constraint.
pyproject.toml
Outdated
| "wheel", | ||
| "cffi>=1.12.0; platform_python_implementation != 'PyPy'", | ||
| "pywayland>=0.4.14", | ||
| "xkbcommon<1.1", |
Owner
There was a problem hiding this comment.
So I don't think pywlroots has a requirement on what version of xkbcommon is installed, but it needs to be the "right" version depending on the version of libxkbcommon is installed. On the github actions installations, that is <1.1, but this is system dependent.
Contributor
Author
There was a problem hiding this comment.
@flacjacket you are right, i change it to not using a maximum version. And also fix the CI issues. 👍
RFCreate
force-pushed
the
dynamic-headers
branch
from
14b1c4f to
522ee1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the XML protocol files to the repository so that when building from source, the header files are created dynamically. This has the benefit that the generated headers are specifically created for the
wayland-scannerandwayland-protocolsversions installed on the targeted system.