Skip to content

Fix: remove default args in pre-commit #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RFCreate wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −9
Open

Fix: remove default args in pre-commit #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8eed370
ci: install in editable mode for faster performance
RFCreate Dec 3, 2025
6a533d7
fix(mypy): remove default args in pre-commit, i.e ignore-missing-imports
RFCreate Dec 3, 2025
fab53a6
fix(coveralls): bump version
RFCreate Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@ jobs:
echo "XDG_RUNTIME_DIR=/tmp" >> $GITHUB_ENV
- name: Install Python dependencies
run: |
pip install .[ci]
pip install -e .[ci]
python pywayland/ffi_build.py
python -m pywayland.scanner --with-protocols
- name: Run unit tests
run: |
pip install .[test]
pip install -e .[test]
pytest --cov pywayland --cov-report term-missing
- name: Push coverage
run: coveralls --service=github
Expand Down Expand Up @@ -139,12 +139,12 @@ jobs:
echo "XDG_RUNTIME_DIR=/tmp" >> $GITHUB_ENV
- name: Install Python dependencies
run: |
pip install .[ci]
pip install -e .[ci]
python pywayland/ffi_build.py
python -m pywayland.scanner --with-protocols
- name: Build docs
run: |
pip install .[docs]
pip install -e .[docs]
sphinx-build -W -b html doc doc/_build/html
pre-commit-test:
name: pre-commit test
Expand All @@ -171,7 +171,7 @@ jobs:
echo "XDG_RUNTIME_DIR=/tmp" >> $GITHUB_ENV
- name: Install Python dependencies
run: |
pip install .[ci]
pip install -e .[ci]
python pywayland/ffi_build.py
python -m pywayland.scanner --with-protocols
- name: Run pre-commit test
Expand Down Expand Up @@ -201,12 +201,12 @@ jobs:
echo "XDG_RUNTIME_DIR=/tmp" >> $GITHUB_ENV
- name: Install Python dependencies
run: |
pip install .[ci]
pip install -e .[ci]
python pywayland/ffi_build.py
python -m pywayland.scanner --with-protocols
- name: Run packaging test
run: |
pip install .[packaging]
pip install -e .[packaging]
check-manifest
python setup.py check -m -s
python -m build --sdist
Expand Down
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ repos:
rev: v1.18.2
hooks:
- id: mypy
args: []
files: "^(pywayland|example)\/.*"
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ ci = ["setuptools>=77.0.0"]
test = [
"pytest",
"pytest-cov",
"coverage>=6.5.0",
"coveralls>=3.3.1",
"coverage>=7.13.0",
"coveralls>=4.0.2",
]
docs = [
"sphinx",
Expand Down