Conversation
…s -> opensearch message_backlog_size: 1
…ssage_backlog_size: 2500
…s about queue sizes; add state reporting for terminal events
…cle across components - unify component lifecycle by introducing async setup/shut_down across NG components - remove legacy _shut_down pattern and simplify base Component shutdown logic - align Connector/Input/Output/Processor lifecycle interfaces - fix kafka output delivery semantics by setting DELIVERED only via on_delivery callback - improve kafka error handling (BufferError retry, KafkaException -> FAILED) - ensure proper resource cleanup (consumer unsubscribe/close, producer flush, opensearch context close) - improve worker shutdown by cancelling only unfinished tasks # Conflicts: # logprep/ng/connector/opensearch/output.py
- remove docker compose teardown from SIGINT handler to avoid interfering with active OpenSearch requests - introduce coordinated shutdown via _shutdown_requested flag - add shutdown checkpoints to abort benchmark flow safely - ensure compose teardown happens only in controlled finally blocks - fix intermittent 503 errors during OpenSearch _count caused by concurrent shutdown
- remove docker compose teardown from SIGINT handler to avoid interfering with active OpenSearch requests - introduce coordinated shutdown via _shutdown_requested flag - add shutdown checkpoints to abort benchmark flow safely - ensure compose teardown happens only in controlled finally blocks - fix intermittent 503 errors during OpenSearch _count caused by concurrent shutdown
…le shutdown semantics
… (unsubscribe only needed for dynamic topic switching during runtime)
…with awaitable delivery futures
… and align with project naming conventions
…OverRide decorator for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Assignee
Documentation
Code Quality
How did you verify that the changes work in practice?
Reviewer
The rendered docs for this PR can be found here.