Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough給付金コース権限を持つユーザー向けに、表示中プラクティスとその「元プラクティス／給付金コース」へ切り替えるピル型ナビと説明文をビューに追加。併せてカテゴリ／プラクティス／コース／ユーザー関連のDBおよびテストフィクスチャを追加・更新し、システムテストと一部セレクタを修正しました。 Changes
Sequence Diagram(s)（該当なし） Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
s-tone-gs
force-pushed
the
feature/add-cross-link-grant-course-practices
branch
from
bc3e588 to
f559630
Compare
|
@machida |
|
@s-tone-gs 連絡ありがとうございます！はい！その状態で大丈夫ですー |
|
@machida |
|
了解です！ |
|
@s-tone-gs デザイン入れましたー |
|
@machida |
s-tone-gs
force-pushed
the
feature/add-cross-link-grant-course-practices
branch
from
0db21a9 to
ece588c
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
test/fixtures/courses_categories.yml (1)
141-144:⚠️ Potential issue | 🔴 Critical
courses_category29が重複していて fixture が壊れます。Line 146 で同じキーを再定義しているため、Line 141 の
course4向けエントリが上書きされるか、fixture の読み込み自体が失敗します。新規エントリは未使用のキー名にしてください。🔧 修正例
-courses_category29: +courses_category30: course: course5 category: category24 position: 1Also applies to: 146-149
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@test/fixtures/courses_categories.yml` around lines 141 - 144, The fixture defines the same mapping key courses_category29 twice, which breaks loading and overwrites the course4/category3 entry; fix by renaming the later duplicate key to a unique unused key (e.g., courses_category30) so both entries (the one referencing course4/category3/position:3 and the later entry) coexist; update any tests or references expecting the new key if necessary and ensure no other keys are duplicated in test/fixtures/courses_categories.yml.db/fixtures/discord_profiles.yml (1)
334-337:⚠️ Potential issue | 🔴 Critical
discord_profile_new-mentorの重複で既存 seed が壊れます。Line 339 で
discord_profile_new-mentorを再定義しているので、Line 334 のnew-mentor用プロフィールが上書きされるか、YAML の読み込みで失敗します。grant-course用に別キーへリネームしてください。🔧 修正例
-discord_profile_new-mentor: +discord_profile_grant-course: user: grant-course account_name: grant-course times_url:Also applies to: 339-342
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@db/fixtures/discord_profiles.yml` around lines 334 - 337, The YAML seed defines duplicate keys "discord_profile_new-mentor" causing overwrite or parse errors; rename the second occurrence used for the grant-course profile to a unique key (e.g., "discord_profile_grant-course" or "discord_profile_new-mentor-grant-course") so both profiles exist separately, update any references that expect the grant-course profile to use the new key, and ensure the entries at the duplicate blocks (the one starting at Line 334 and the repeated block at 339-342) are distinct.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/system/questions/change_user_test.rb`:
- Line 27: Replace fragile ID-based selectors that target
'#choices--js-choices-user-item-choice-14' with a class-and-text based selector:
locate the choice by using the '.choices__item--choice' selector together with
the existing text matcher (text: 'hatsuno') and call click on that element;
update all three occurrences that currently use
'#choices--js-choices-user-item-choice-14' (the find calls at the three
locations) to use '.choices__item--choice' + text matcher instead to avoid ID
brittleness.
---
Outside diff comments:
In `@db/fixtures/discord_profiles.yml`:
- Around line 334-337: The YAML seed defines duplicate keys
"discord_profile_new-mentor" causing overwrite or parse errors; rename the
second occurrence used for the grant-course profile to a unique key (e.g.,
"discord_profile_grant-course" or "discord_profile_new-mentor-grant-course") so
both profiles exist separately, update any references that expect the
grant-course profile to use the new key, and ensure the entries at the duplicate
blocks (the one starting at Line 334 and the repeated block at 339-342) are
distinct.
In `@test/fixtures/courses_categories.yml`:
- Around line 141-144: The fixture defines the same mapping key
courses_category29 twice, which breaks loading and overwrites the
course4/category3 entry; fix by renaming the later duplicate key to a unique
unused key (e.g., courses_category30) so both entries (the one referencing
course4/category3/position:3 and the later entry) coexist; update any tests or
references expecting the new key if necessary and ensure no other keys are
duplicated in test/fixtures/courses_categories.yml.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f4258cc7-36b3-45b2-b9f6-2d162cc26a23
📒 Files selected for processing (17)
app/views/practices/show.html.slimdb/fixtures/categories.ymldb/fixtures/categories_practices.ymldb/fixtures/courses_categories.ymldb/fixtures/discord_profiles.ymldb/fixtures/practices.ymldb/fixtures/talks.ymldb/fixtures/users.ymltest/fixtures/categories.ymltest/fixtures/categories_practices.ymltest/fixtures/courses_categories.ymltest/fixtures/discord_profiles.ymltest/fixtures/practices.ymltest/fixtures/talks.ymltest/fixtures/users.ymltest/system/practices_test.rbtest/system/questions/change_user_test.rb
s-tone-gs
force-pushed
the
feature/add-cross-link-grant-course-practices
branch
from
ece588c to
876d53a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
s-tone-gs
force-pushed
the
feature/add-cross-link-grant-course-practices
branch
from
876d53a to
4eb3de5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
s-tone-gs
force-pushed
the
feature/add-cross-link-grant-course-practices
branch
2 times, most recently
from
48ba406 to
9398667
Compare
給付金コースの受講生を追加した影響で落ちたテストの修正 idで要素を指定していたため安定性の無いテストになっていた テキストで要素を指定しているためID固定出の指定は不要だと判断し修正した
テキストが表示されないことをチェックするだけでは エラーでページが表示されなかった場合も通ってしまうので修正した
テキストのみのチェックではなくパスもチェックしてより堅牢にした
s-tone-gs
force-pushed
the
feature/add-cross-link-grant-course-practices
branch
from
9398667 to
d298c57
Compare
|
@zecky1120 お疲れ様です！レビュー依頼させていただきました！よろしくお願いいたします🙇♂️ |
|
@s-tone-gs |
|
@s-tone-gs もしくは左下のアイコンユーザーで給付金コースを受講しているユーザーはいますか？ |
|
@zecky1120
お忙しいところ恐縮ですが、よろしくお願いします！
いないはずですね🤔 |
zecky1120
left a comment
zecky1120
left a comment
There was a problem hiding this comment.
@s-tone-gs
確認できました〜✨ OKです
|
@zecky1120 @okuramasafumi |
3 participants
Issue
概要
給付金コースのプラクティスと、その元になっているプラクティスとの間で、給付金コースを受講している生徒のみが使用できる相互リンクを作成した。
変更確認方法
bin/rails db:seed:replantを実行bin/setupを実行Screenshot
変更前
変更後
Summary by CodeRabbit
新機能
データ
テスト