Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Issue#9640
7d70cd9 to
a435a7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
注意事項
概要
def organizersがhas_manyの関連メソッドを上書きしているため、RegularEventからOrganizer情報を取得しようとするとUserが帰ってくるregualrevent.organizersでOrganizerを操作したいのに、この仕様のためリレーションを仕様しての参照や操作ができなくなっているdef organizersは各所から依存されており影響箇所が多いのと、oganizersでUser情報を取得できること自体はRails的には違和感はないOrganizerが中間モデルらしくない命名となってしまっているのが原因のため、本PRにてRegularEventOrganizerという命名に変更する変更確認方法
chore/rename-of-organizers-tableをローカルに取り込むbin/rails db:migrateを実行bin/devを実行kimuraでログインkimura(crated_at: 2014-1-1)、tomo(crated_at: 2021-1-1)、thirty(crated_at: current_dateで作成される)などを登録し、イベント詳細画面にてcreated_at順になっていることを確認7.
kimuraで退会or休会処理を行った際、自身が主催から削除されているかをkomagataで確認するScreenshot
画面変更はなし