Skip to content

Fix Docker service image references in GitHub Actions workflow#113

Merged
ChasNelson1990 merged 2 commits intochas/update-pythonfrom
copilot/sub-pr-112
Dec 8, 2025
Merged

Fix Docker service image references in GitHub Actions workflow#113
ChasNelson1990 merged 2 commits intochas/update-pythonfrom
copilot/sub-pr-112

Conversation

Copy link

Copilot AI commented Dec 8, 2025

GitHub Actions workflow was failing because Solr and PostgreSQL service containers used incorrect matrix variables, generating malformed image tags with double colons.

Changes

  • Solr service: Use matrix.ckan-solr-version instead of matrix.ckan-version
  • PostgreSQL service: Use matrix.ckan-postgres-version instead of matrix.ckan-version

Before/After

# Before: Invalid image reference
services:
  solr:
    image: ckan/ckan-solr:${{ matrix.ckan-version }}
    # Expands to: ckan/ckan-solr:ckan-dev:2.9-py3.9 (invalid: two colons)

# After: Valid image reference  
services:
  solr:
    image: ckan/ckan-solr:${{ matrix.ckan-solr-version }}
    # Expands to: ckan/ckan-solr:2.9-solr8 (valid)

This ensures proper service container initialization across all CKAN versions (2.9, 2.10, 2.11).


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

The Solr and PostgreSQL service containers were using the wrong matrix variable (ckan-version instead of ckan-solr-version and ckan-postgres-version), resulting in invalid Docker image references with two colons.

Co-authored-by: ChasNelson1990 <7795189+ChasNelson1990@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing tests in GitHub Actions workflow Fix Docker service image references in GitHub Actions workflow Dec 8, 2025
Copilot AI requested a review from ChasNelson1990 December 8, 2025 16:03
@ChasNelson1990 ChasNelson1990 marked this pull request as ready for review December 8, 2025 16:04
@ChasNelson1990 ChasNelson1990 merged commit d246660 into chas/update-python Dec 8, 2025
6 of 10 checks passed
@ChasNelson1990 ChasNelson1990 deleted the copilot/sub-pr-112 branch December 8, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants