Draft
Conversation
- Replace SingleNestedBlock config with DynamicAttribute to allow arbitrary key-value config without static fields.json - Add config_projection.go with dynamicToMap, project, and PrepareConfigPatchDynamic for correct clear/sensitive/readonly handling - Add metadata_cache.go for in-process caching of connector metadata - Add ValidateConfig for plan-time field name validation - Point go-fivetran to local module for Sensitive field support
… detection - Update config_projection.go to check prop.Format == "password" instead of prop.Sensitive - Add nil client guard in ValidateConfig (called before Configure by Terraform framework)
…lear nullable fields
Previously:
- Empty string ("") was treated as a clear operation (sent null)
- Removing any field from HCL sent null to the API regardless of nullability
Now:
- Empty strings pass through as valid values (needed for pattern, null_sequence, etc.)
- Field removal only sends null if the metadata marks the field nullable (Optional<T> in Java)
- Non-nullable fields removed from HCL are omitted from the PATCH entirely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.