Skip to content

Conversation

@fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Sep 18, 2025

PR Overview

Package version introduced in this PR:

  • v1.0.1

This PR addresses the following Issue/Feature(s):

  • GA-1004327

Summary of changes:

  • In int_apple_store__date_spine updated the run query to use the staging refs instead of the sources.
  • This is to prevent run errors if one the sources is missing since staging will fill empty tables.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-catfritz fivetran-catfritz self-assigned this Sep 18, 2025
@@ -1,32 +1,36 @@
{{ config(materialized='table') }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to dbt_project.yml

Comment on lines +30 to +31
int_apple_store__date_spine:
+materialized: table
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved here from the model config.

@fivetran-catfritz fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label Sep 19, 2025
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one update suggestion and a FR creation request.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still referencing apple_store_source on line 11 of this file. We need to update this to apple_store to reflect the current state of the consolidated package.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I noticed the identifier variables don't follow our standard naming convention:

source_name + `_` + source_table_name + `_identifier`.

We should update the identifiers and the references to swap in the following way:

  • apple_store_crash_daily_identifier -> apple_store_app_crash_daily_identifier

This doesn't need to be updated in this release, but please create a FR for us to update this in a future breaking change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue opened. #43

@fivetran-catfritz fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Sep 19, 2025
@fivetran-catfritz fivetran-catfritz merged commit 65d3d78 into main Sep 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants