-
Notifications
You must be signed in to change notification settings - Fork 3
Consolidate source + remove tests #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Q2 FY26: Apply automated update. * Q2 FY26: Update auto-release workflow only. --------- Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
fivetran-jamie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three required changes:
- See my suggestion about adding the namespace to an
adapter.dispatchcall - Adjust the
run_models.shfile so that the freshness test is run after the data is seeded (currently it's before, so it's just erroring out) - Regen the docs :)
I don't wanna hold up approval after signing off, so as long as these are addressed, you're good to go
| @@ -0,0 +1,33 @@ | |||
| {% macro get_date_from_string(string_text) %} | |||
| {{ return(adapter.dispatch('get_date_from_string') (string_text)) }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {{ return(adapter.dispatch('get_date_from_string') (string_text)) }} | |
| {{ return(adapter.dispatch('get_date_from_string', 'apple_store') (string_text)) }} |
According these docs we gotta provide the namespace to dispatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied these changes!
Summary
This PR is to combine the source and transform packages and remove tests not compatible with dbt Fusion 1.10.6+.
Please check the below automated updates were successful:
MANUAL UPDATES
Q2 FY26 Automatic Package UpdatesPR.Source + Transform Consolidation
dbt Fusion Compatibility
dbt_utils.unique_combination_of_columnstestYAML & Config Updates
+schemaand+materializationfor the staging models indbt_project.yml.README