Open
Conversation
fishpepper
requested changes
Jan 1, 2025
Owner
fishpepper
left a comment
fishpepper
left a comment
There was a problem hiding this comment.
thanks for the contribution! looks really good. could you have a look at my comments?
|
|
||
| ## TODO | ||
| - Add a protection to stop users from overwriting the bootloader area | ||
| - Information about decompiling the dumped flash memory |
Owner
There was a problem hiding this comment.
i would drop the line about decompiling, its not the scope of this tool
Owner
There was a problem hiding this comment.
i would drop this, add the dumps directory to the toplevel gitignore instead
(or more preferably: drop prepending dumps/ in the file writer, see comment below)
| dynamic_ncols=True, | ||
| unit_scale=True, | ||
| ): | ||
| sorted_byte_list = byte_list.most_common() |
Owner
There was a problem hiding this comment.
what is the sorting good for? speedup if there are many equal values?
Comment on lines
+306
to
+307
| ih.tofile("dumps/" + filename, format='hex') | ||
| ih.tofile("dumps/" + filename + ".bin", format='bin') |
Owner
There was a problem hiding this comment.
i would not prepend dumps here, you can always pass dumps/file.hex as commandline param. e.g. i use it to dump to /tmp/dump.hex
adding bin is nice :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AN945: EFM8 Factory Bootloader User's GuidePDF for VVDD information