Conversation
- Create permission-utils.ts with authoritative role whitelist (39 roles) - Add MEMBER_FLAGS_QUERY to queries.ts for DRY principle - Update roles.ts with isFisher support and role constant references - Fix isArrivalsPayerCouncil mapping (was incorrectly 'tellerCouncil') - Update login.ts and refreshToken.ts to use MEMBER_FLAGS_QUERY - Add comprehensive role derivation tests - Ensure all supported roles from permission-utils are properly returned
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ecognize-and-return-the-full-set-of-roles-from-permission-utils.ts Syn 47 auth service must recognize and return the full set of roles from permission utils.ts
- Remove isSheepSeekerForStream flag from RoleFlags interface - isSheepSeekerForStream was not in ticket requirements for supported roles - Fixes TypeScript error in role-derivation.test.ts - All 27 tests passing
…ecognize-and-return-the-full-set-of-roles-from-permission-utils.ts fix: remove unsupported isSheepSeekerForStream from RoleFlags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Auth Service: full role whitelist + shared flags query (SYN-47)
Summary
Add authoritative role whitelist + helpers in permission-utils.ts (39 roles).
Centralize MEMBER_FLAGS_QUERY used by login + refresh token.
Update role derivation to use constants + validation; add isFisher.
Fix isArrivalsPayerCouncil mapping and Neo4j relationship names.
Add role derivation tests covering all categories.
Testing
npm test -- role-derivation.test.ts
Issue
Closes SYN-47