Skip to content

Remove unnecessary addBlock param #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a2br wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unnecessary addBlock param #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ class Chain {
}

// Add a new block to the chain if valid signature & proof of work is complete
addBlock(transaction: Transaction, senderPublicKey: string, signature: Buffer) {
addBlock(transaction: Transaction, signature: Buffer) {
const verify = crypto.createVerify('SHA256');
verify.update(transaction.toString());

const isValid = verify.verify(senderPublicKey, signature);
const isValid = verify.verify(transaction.payer, signature);

if (isValid) {
const newBlock = new Block(this.lastBlock.hash, transaction);
Expand Down Expand Up @@ -112,7 +112,7 @@ class Wallet {
sign.update(transaction.toString()).end();

const signature = sign.sign(this.privateKey);
Chain.instance.addBlock(transaction, this.publicKey, signature);
Chain.instance.addBlock(transaction, signature);
}
}

Expand Down