Generalise linear solvers #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommbendall
added
enhancement
…set to 0 with a flag
jshipton
reviewed
Dec 19, 2025
gusto/solvers/preconditioners.py
Outdated
| self.W = equations.function_space | ||
| self.W_hyb = MixedFunctionSpace((self.Vu_broken, self.Vrho, self.Vtrace)) | ||
|
|
||
| # Define |
Contributor
There was a problem hiding this comment.
do we need more detail here? define what?
jshipton
reviewed
Dec 19, 2025
jshipton
reviewed
Dec 19, 2025
jshipton
reviewed
Dec 19, 2025
| """ | ||
| This module provides PETSc dictionaries for nonlinear and linear problems. | ||
| The solvers provided here are used for solving linear problems on mixed |
Contributor
There was a problem hiding this comment.
I"m a little bit confused by these two sentences - the first mentions nonlinear and linear problems but the second just says this is for linear problems...
Collaborator
There was a problem hiding this comment.
I was future proofing for nonlinear solvers in the future, but have left as linear for now
jshipton
reviewed
Dec 19, 2025
jshipton
reviewed
Dec 19, 2025
jshipton
reviewed
Dec 19, 2025
jshipton
reviewed
Dec 19, 2025
| # BCs, Forcing and Linear Solver --------------------------------------- | ||
| self.bcs = equation_set.bcs | ||
| self.forcing = Forcing(equation_set, self.implicit_terms, self.alpha) | ||
| if linear_solver is None: |
Contributor
There was a problem hiding this comment.
I don't think we want to keep this argument
jshipton
reviewed
Dec 19, 2025
jshipton
reviewed
Dec 19, 2025
| passed in. Defaults to False. | ||
| reference_dependent: this indicates that the solver Jacobian should | ||
| be rebuilt if the reference profiles have been updated. | ||
| appctx: appctx for the underlying :class:`LinearVariationalSolver`. |
Contributor
There was a problem hiding this comment.
more doc changes required above to remove obsolete arguments and put docs in same order as args
jshipton
reviewed
Dec 19, 2025
| self.equation.update_reference_profiles() | ||
| self.solver.invalidate_jacobian() | ||
|
|
||
| # TODO: Issue X is to address this reference profile update bug (pythonPC update not called) |
Contributor
There was a problem hiding this comment.
do we have an issue number?
jshipton
reviewed
Dec 19, 2025
| for field_name in field_names: | ||
|
|
||
| if field_name not in prognostic_names: | ||
| logger.debug(f'Semi-Implicit Quasi Newton: Zeroing xrhs for {field_name}') |
Co-authored-by: Dr Jemma Shipton <j.shipton@exeter.ac.uk>
Co-authored-by: Dr Jemma Shipton <j.shipton@exeter.ac.uk>
Co-authored-by: Dr Jemma Shipton <j.shipton@exeter.ac.uk>
Co-authored-by: Dr Jemma Shipton <j.shipton@exeter.ac.uk>
…roject/gusto into auxiliary-equation-pc
This was referenced Jan 4, 2026
Co-authored-by: Dr Jemma Shipton <j.shipton@exeter.ac.uk>
tommbendall
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.