Skip to content

Potential issue in equivalent buoyancy formulation of the ThermalSWSolver class #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nhartney wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Potential issue in equivalent buoyancy formulation of the ThermalSWSolver class #646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gusto/solvers/linear_solvers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,7 @@ def _setup_solver(self):
# compute q_v using q_sat to partition q_t into q_v and q_c
self.q_sat_func = Function(VD)
self.qvbar = Function(VD)
self.q_v = Function(VD)
qtbar = split(equation.X_ref)[3]

# set up interpolators that use the X_ref values for D and b_e
Expand All @@ -669,6 +670,9 @@ def _setup_solver(self):

# bbar was be_bar and here we correct to become bbar
bbar += equation.parameters.beta2 * self.qvbar
# Should we also be doing the same for b?
# (ie: b was b_e and here we correct it to become b?)
b += equation.parameters.beta2 * self.q_v

n = FacetNormal(equation.domain.mesh)

Expand Down