Fix Gusto following changes to value_size and value_shape #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommbendall
added
bug
jshipton
approved these changes
Nov 18, 2024
Contributor
jshipton
left a comment
jshipton
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @tommbendall !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates parts of Gusto getting
value_shapeorvalue_sizefrom theufl_element, to now get it from the function space directly. This fixes the broken main branch following the Firedrake PR: firedrakeproject/firedrake#3862