Conversation
JDBetteridge
force-pushed
the
JDBetteridge/python312
branch
3 times, most recently
from
7dd24b1 to
7513306
Compare
JDBetteridge
commented
May 13, 2024
JDBetteridge
force-pushed
the
JDBetteridge/python312
branch
from
603a632 to
5a1b7e9
Compare
JDBetteridge
commented
May 30, 2024
JDBetteridge
commented
May 30, 2024
JDBetteridge
commented
May 30, 2024
This was referenced May 30, 2024
ksagiyam
reviewed
May 30, 2024
JDBetteridge
commented
May 30, 2024
Contributor
|
FYI, I went ahead and did the FIAT merge. Nothing was changed pointing to various numpy versions. All it had was |
JDBetteridge
force-pushed
the
JDBetteridge/python312
branch
from
76d4fea to
fc6a919
Compare
This was referenced Jun 19, 2024
Closed
dham
previously requested changes
Jun 19, 2024
Member
dham
left a comment
dham
left a comment
There was a problem hiding this comment.
rebase and lose branches of pytorch and thetis.
connorjward
requested changes
Jun 19, 2024
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
please update page about 3.8 and also mumble mumble ARM support (to badly quote @JDBetteridge)
JDBetteridge
force-pushed
the
JDBetteridge/python312
branch
from
bb90fca to
129133f
Compare
connorjward
previously approved these changes
Jun 20, 2024
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
This all looks good to me!
Ig-dolci
pushed a commit
that referenced
this pull request
Jul 6, 2024
* Fix cython files for Cython 3.0 * Install with latest numpy * Update documentation to Python3.9-3.12 --------- Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is now ready to land, once numpy 2.0 is released on 16th June
https://numpy.org/news/#numpy-20-release-date-june-16
Linked PRs:
FIATDONEPyOP2DONETSFCDONEThetisDONETinyASMWe want to incorperate this into Firedrake, rather than merge this PR, see 3604 instead DONECode Coverage
Code coverage can be re-enabled when Ubuntu 24.04 updates to Python 3.12.4, see python/cpython#119118 for the performance regression