Merged
Conversation
Contributor
|
What's the current status of this? BDMCF/DPC works fantastically well for an application of mine and I'd love to see it merged. |
Contributor
|
Was the conclusion that these elements are broken in some way at lowest order? |
Contributor
|
Yes. I've added a test for the H(div) and H(curl) Riesz maps. They converge at all orders k=1,2,3 for RTC[F/E], and for k=2,3 for BDMC[F/E], but not for BDMC[F/E] with k=1. This is the solution chosen for the MMS:
This is the solution for the H(div) Riesz map at k=1:
@dham suggested it was a local ordering bug. |
tommbendall
reviewed
Jan 25, 2021
This was referenced Jul 25, 2023
JDBetteridge
approved these changes
Sep 20, 2023
Member
JDBetteridge
left a comment
JDBetteridge
left a comment
There was a problem hiding this comment.
The empty review
Reviewed in meeting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the BDMC elements to Firedrake, and is linked to three other PRs in other firedrakeproject packages:
FIAT: firedrakeproject/fiat#18
FInAT: FInAT/FInAT#55
tsfc: firedrakeproject/tsfc#197
The Firedrake component adds three unit tests for the new elements.