Conversation
pbrubeck
commented
Mar 22, 2025
pbrubeck
commented
Mar 22, 2025
9f9e525 to
73ffcd2
Compare
dham
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
variant="mimetic"for the de Rham complex on quads/hexes ("Q", "NCE", "NCF", "DQ").This is the element variant required for Low-Order-Refined equivalent preconditioners (a.k.a. connect-the-dots). See https://epubs.siam.org/doi/full/10.1137/22M1486534
The "Q" variant is just the tensor product of GLL. The DQ variant is the tensor product of basis functions dual to histopolation on the GLL subgrid. Histopolation degrees of freedom are integral averages on an interval, in this case between consecutive GLL nodes.
Supersedes FInAT/FInAT#54