DGStepper: support TimeQuadratureLabel and TimeDegreeEstimator#190
Open
DGStepper: support TimeQuadratureLabel and TimeDegreeEstimator#190
Conversation
Collaborator
ScottMacLachlan
left a comment
ScottMacLachlan
left a comment
There was a problem hiding this comment.
Looks good to me, and it fixes both my MFE and real code. Do we want to adapt the MFE as a test?
rckirby
requested changes
Jan 26, 2026
Collaborator
rckirby
left a comment
rckirby
left a comment
There was a problem hiding this comment.
Looks clean, and seems to fix the BC issue (I'd seen that before too).
If @ScottMacLachlan could add some Stokes-ish BC test to make sure this sticks, that would be great.
Not sure the etiquette of asking one person to make changes on somebody else's PR, but...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.