Pass **kwargs through AdaptiveTimeStepper to support options_prefix#189
Merged
pbrubeck merged 3 commits intofiredrakeproject:masterfrom Jan 24, 2026
Merged
Conversation
AdaptiveTimeStepper.__init__ did not accept **kwargs, which meant that valid base kwargs like options_prefix could not be passed through to the NonlinearVariationalSolver. This caused a TypeError when users tried to use adaptive timestepping with a custom solver prefix. This fix adds **kwargs to AdaptiveTimeStepper.__init__ and passes it to the parent class, consistent with StageDerivativeTimeStepper. Fixes firedrakeproject#188
sghelichkhani
added a commit
to g-adopt/g-adopt
that referenced
this pull request
Jan 23, 2026
Point to sghelichkhani/Irksome@fix-adaptive-options-prefix which adds **kwargs support to AdaptiveTimeStepper, allowing options_prefix to be passed through to the solver for adaptive timestepping. See: firedrakeproject/Irksome#189
pbrubeck
reviewed
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**kwargstoAdaptiveTimeStepper.__init__and pass it to the parent classProblem
AdaptiveTimeStepperdid not accept**kwargs, which meant that valid base kwargs likeoptions_prefixcould not be passed through to theNonlinearVariationalSolver. This caused aTypeErrorwhen users tried to use adaptive timestepping with a custom solver prefix:Fix
This PR adds
**kwargstoAdaptiveTimeStepper.__init__and passes it to the parent classStageDerivativeTimeStepper, which already accepts and passes through**kwargs. This makesAdaptiveTimeStepperconsistent with the non-adaptive timesteppers.Fixes #188
Test
options_prefixis now correctly passed through to the solver for adaptive timestepping