Open
Conversation
pbrubeck
force-pushed
the
pbrubeck/hamiltonian
branch
from
e946a9b to
a8f7c7d
Compare
pbrubeck
force-pushed
the
pbrubeck/hamiltonian
branch
from
61fa98a to
056dbe7
Compare
pbrubeck
commented
Oct 24, 2025
| equation (7.17) of Boris Andrews' thesis for the particular formulation. | ||
| .. note:: | ||
|
|
||
| Here, we consider the framework in Andrews and Farrell, "Enforcing conservation laws and dissipation |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| Here, we consider the framework in Andrews and Farrell, "Enforcing conservation laws and dissipation | |
| Alternatively, one might consider the framework in Andrews and Farrell, "Enforcing conservation laws and dissipation |
rckirby
requested changes
Nov 21, 2025
Collaborator
rckirby
left a comment
rckirby
left a comment
There was a problem hiding this comment.
We need to make sure we have something that's pretty close to Boris' thesis, so I recommend keeping my original auxiliary BBM demo and moving your changes to a different demo.
We also need to bring these demos up-to-date with moving Galerkin behind TimeStepper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.