Open
Conversation
…irksome into rckirby/galerkin_label
…Irksome into rckirby/galerkin_label
rckirby
reviewed
May 28, 2025
Collaborator
rckirby
left a comment
rckirby
left a comment
There was a problem hiding this comment.
Mostly good (I think).
- Do we know that the approach being used here doesn't explode the complexity when we use projectors? How would we check?
- Can we get a demo before merging.
| ref_el = L_test.get_reference_element() | ||
| phisub = vecconst(Legendre(ref_el, L_test.degree()).tabulate(0, qpts)[(0,)].T) | ||
|
|
||
| # preprocess time derivatives |
Collaborator
There was a problem hiding this comment.
comment is no longer accurate here.
| Q = o.quadrature | ||
| assert order+1 <= len(self.phi) | ||
|
|
||
| # compute the hierarchical mass matrix (always the identity) |
Collaborator
There was a problem hiding this comment.
If it's the identity why do we compute it?
|
|
||
| # compute the L2-Riesz representation by undoing the integral against the test coefficient | ||
| fc = sum(it.integrand() for it in Fc.integrals()) | ||
| fproj = expand_derivatives(diff(fc, c)) |
Collaborator
There was a problem hiding this comment.
This seems unclear to me what's actually happening.
…/Irksome into pbrubeck/time-projector
pbrubeck
commented
Jul 31, 2025
irksome/galerkin_stepper.py
Outdated
Collaborator
Author
There was a problem hiding this comment.
Here we are solving for an update
pbrubeck
force-pushed
the
rckirby/galerkin_label
branch
from
9c20cbe to
88700dd
Compare
pbrubeck
commented
Nov 8, 2025
pbrubeck
commented
Nov 8, 2025
pbrubeck
commented
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable projection-in-time of expressions (usually the Gateaux derivative of a conserved quantity). This is useful to eliminate auxiliary variables.