fix(vm_syscall): only extract input region for successful execs#429
Draft
0xalpharush wants to merge 1 commit intofiredancer-io:agave-v3.1.0-beta.0from
Draft
fix(vm_syscall): only extract input region for successful execs#4290xalpharush wants to merge 1 commit intofiredancer-io:agave-v3.1.0-beta.0from
0xalpharush wants to merge 1 commit intofiredancer-io:agave-v3.1.0-beta.0from
Conversation
233cbe2 to
578acea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a CPI call fails, Agave doesn't perform update_caller_account_region and the memory region may contain stale pointers. Given Agave doesn't read these in prod, it is fine. But the syscall harness is reading this intermediary state where there's a pending change (callee triggers realloc) that's never realized by the caller. One solution is to only call
mem_region_to_input_data_regionwhen the program returnsStableResult::Ok.Note, this will require updating test-vectors and FD's syscall harness.