Constrain ticks_per_slot in block harness#412
Open
ripatel-fd wants to merge 1 commit intofiredancer-io:agave-v3.1.0-beta.0from
Open
Constrain ticks_per_slot in block harness#412ripatel-fd wants to merge 1 commit intofiredancer-io:agave-v3.1.0-beta.0from
ripatel-fd wants to merge 1 commit intofiredancer-io:agave-v3.1.0-beta.0from
Conversation
- Fixes bug where slots_per_year parameter differs between bank and genesis config (U.B. in the SVM) - Fixes bug where slots_per_year is taken from epoch context even though it can be fully derived from genesis config - Constrains ticks_per_slot (a hardcoded genesis parameter) to reasonable values, which would otherwise cause invalid floating points (denormals, infinite values) in epoch bounaries
cmoyes-jump
approved these changes
Nov 20, 2025
Contributor
Author
|
Need to rewrite test vectors to have correct ticks_per_slot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and genesis config (U.B. in the SVM)
though it can be fully derived from genesis config
reasonable values, which would otherwise cause invalid floating
points (denormals, infinite values) in epoch bounaries