ssping: use close+recreate instead of connect(AF_UNSPEC) for reliable TCP cleanup#8664
Draft
Copilot wants to merge 3 commits intoptaffet/snapshot-ping-tcpfrom
Draft
ssping: use close+recreate instead of connect(AF_UNSPEC) for reliable TCP cleanup#8664Copilot wants to merge 3 commits intoptaffet/snapshot-ping-tcpfrom
Copilot wants to merge 3 commits intoptaffet/snapshot-ping-tcpfrom
Conversation
… TCP cleanup Co-authored-by: ripatel-fd <113896534+ripatel-fd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update snapct to use tcp-based ping for peer reachability
ssping: use close+recreate instead of connect(AF_UNSPEC) for reliable TCP cleanup
Mar 3, 2026
e13d6cc to
92cfb91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connect(AF_UNSPEC)on TCP sockets is a Linux-specifictcp_disconnect()extension that does not reliably send RST/FIN in all connection states, leaving stale TCP state at the remote end.Replace with
close()+ freshsocket()which guarantees FIN delivery for established connections and proper kernel cleanup for SYN_SENT.fd_ssping.c—remove_fdesc_idx()now closes the socket and creates a fresh nonblocking TCP socket withTCP_NODELAY, instead of attemptingconnect(AF_UNSPEC)fd_snapct_tile.seccomppolicy— Allowcloseandsetsockopt(TCP_NODELAY)on ping fds (previously blocked to match the socket-reuse design)fd_snapct_tile_seccomp.h— Regenerated (8 fewer BPF instructions from removed ping fd range exclusions)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.