Skip to content

fdctl: fix --topo flag handling#8658

Open
ripatel-fd wants to merge 1 commit intofiredancer-io:mainfrom
riptl:fix-topo-flag
Open

fdctl: fix --topo flag handling#8658
ripatel-fd wants to merge 1 commit intofiredancer-io:mainfrom
riptl:fix-topo-flag

Conversation

@ripatel-fd
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 3, 2026 05:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes fdctl’s --topo lookup by correcting iteration over the global ACTIONS registry, so topology reconstruction properly stops at the NULL sentinel.

Changes:

  • Update reconstruct_topo() in metrics to iterate ACTIONS until *a==NULL.
  • Update reconstruct_topo() in mem to iterate ACTIONS until *a==NULL.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/app/shared/commands/metrics.c Fixes ACTIONS loop termination when selecting an action by --topo.
src/app/shared/commands/mem.c Fixes ACTIONS loop termination when selecting an action by --topo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants