You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reduces memory usage by bounding the store to fixed-32 shreds per FEC set, enabling an increase in max_live_slots from 512 to 4096 (addressing issue #8222) while keeping total locked memory within the 512 GiB limit of target hardware.
Changes:
FD_STORE_DATA_MAX reduced from 63985 to 31840 bytes, reflecting fixed-32 FEC set sizes (32 shreds × 995 bytes payload = 31840, matching FD_SHREDDER_NORMAL_FEC_SET_PAYLOAD_SZ)
Store fec_max sizing formula in topology.c replaced from a temporary hardcoded * 1024UL hack with the semantically correct * FD_SHRED_BLK_MAX / FD_FEC_SHRED_CNT
max_live_slots default increased from 512 to 4096
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File
Description
src/disco/store/fd_store.h
Reduces FD_STORE_DATA_MAX from 63985 to 31840 to reflect fixed-32 FEC set constraint
src/app/firedancer/topology.c
Replaces temporary * 1024UL hack with correct * FD_SHRED_BLK_MAX / FD_FEC_SHRED_CNT formula
The reason will be displayed to describe this comment to others. Learn more.
The comment block above FD_STORE_DATA_MAX still describes the old computation ("67 shreds per FEC set * 955 payloads per shred = 63985 bytes max"), which no longer matches the new value of 31840. The comment should be updated to reflect the fixed-32 basis: 32 shreds per FEC set × 995 bytes payload per shred = 31840 bytes max (matching FD_SHREDDER_NORMAL_FEC_SET_PAYLOAD_SZ in fd_shredder.h).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8222