pktgen: increase buffer depth & housekeeping freq#8588
Open
tristan-carter wants to merge 1 commit intofiredancer-io:mainfrom
Open
pktgen: increase buffer depth & housekeeping freq#8588tristan-carter wants to merge 1 commit intofiredancer-io:mainfrom
tristan-carter wants to merge 1 commit intofiredancer-io:mainfrom
Conversation
tristan-carter
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the fddev pktgen topology/tile tuning to reduce pktgen stalls caused by running out of producer credits when transmitting into the net tile.
Changes:
- Increased
pktgen_outlink ring depth to 32768 to provide more producer credits to pktgen. - Increased pktgen stem housekeeping frequency by setting
STEM_LAZYto ~384µs (matching shred tile behavior).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/app/shared_dev/commands/pktgen/pktgen.c |
Increases pktgen_out link depth to reduce credit exhaustion/backpressure into net tile. |
src/app/shared_dev/commands/pktgen/fd_pktgen_tile.c |
Adjusts STEM_LAZY to run housekeeping more frequently to help prevent prolonged credit starvation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicates the shred tile's house keeping frequency (shown here) and link ring depth (shown here)to solve pktgen running out of producer credits near continuously thus stalling pktgen tx to the net tile.