gui, rpc: support upcoming version format#8492
gui, rpc: support upcoming version format#8492jherrera-jump merged 1 commit intofiredancer-io:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates GUI and RPC JSON output to support an upcoming node version encoding where prerelease information is embedded in the minor field.
Changes:
- Added a
node_version_cstr_printf()helper to format versions with prerelease suffixes derived fromminor’s high bits. - Updated RPC
getClusterNodesresponse to emit the new formattedversionstring. - Updated GUI peer/peers output to emit the new formatted
versionstring.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/discof/rpc/fd_rpc_tile.c |
Formats and prints cluster node versions in RPC output using prerelease-aware logic. |
src/disco/gui/fd_gui_printf.c |
Formats and prints gossip peer versions in GUI JSON output using the same prerelease-aware logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0d80a9e to
959916c
Compare
959916c to
2c77d26
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2c77d26 to
bd1fcdd
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bd1fcdd to
bba906f
Compare
bba906f to
2bf957f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2bf957f to
cba0060
Compare
No description provided.