Skip to content

gui, rpc: support upcoming version format#8492

Merged
jherrera-jump merged 1 commit intofiredancer-io:mainfrom
jherrera-jump:jherrera/version-fixes
Mar 3, 2026
Merged

gui, rpc: support upcoming version format#8492
jherrera-jump merged 1 commit intofiredancer-io:mainfrom
jherrera-jump:jherrera/version-fixes

Conversation

@jherrera-jump
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 26, 2026 17:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GUI and RPC JSON output to support an upcoming node version encoding where prerelease information is embedded in the minor field.

Changes:

  • Added a node_version_cstr_printf() helper to format versions with prerelease suffixes derived from minor’s high bits.
  • Updated RPC getClusterNodes response to emit the new formatted version string.
  • Updated GUI peer/peers output to emit the new formatted version string.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/discof/rpc/fd_rpc_tile.c Formats and prints cluster node versions in RPC output using prerelease-aware logic.
src/disco/gui/fd_gui_printf.c Formats and prints gossip peer versions in GUI JSON output using the same prerelease-aware logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 26, 2026 23:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jherrera-jump jherrera-jump marked this pull request as ready for review February 27, 2026 04:22
Copilot AI review requested due to automatic review settings February 27, 2026 04:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 27, 2026 21:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jherrera-jump jherrera-jump force-pushed the jherrera/version-fixes branch from 2bf957f to cba0060 Compare March 3, 2026 02:05
@jherrera-jump jherrera-jump merged commit 8cc853e into firedancer-io:main Mar 3, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants