genesis: fix calling strtoul on non-null terminated string#8422
Open
two-heart wants to merge 1 commit intofiredancer-io:mainfrom
Open
genesis: fix calling strtoul on non-null terminated string#8422two-heart wants to merge 1 commit intofiredancer-io:mainfrom
two-heart wants to merge 1 commit intofiredancer-io:mainfrom
Conversation
get_token_to_eol prevents oob read, but would still except numeric prefixes -- and is just wrong usage
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes unsafe parsing of the HTTP Content-Length header in the genesis client by avoiding strtoul on a non–NUL-terminated buffer returned by picohttpparser.
Changes:
- Add a length-bounded decimal
ulongparser for header values. - Use the new parser in
rpc_phr_content_lengthto reject non-digit suffixes and avoid out-of-bounds reads.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_token_to_eol prevents oob read, but would still except numeric prefixes -- and is just wrong usage