Draft
Conversation
ripatel-fd
reviewed
Jan 26, 2026
src/disco/metrics/metrics.xml
Outdated
| - Dup = Duplicate | ||
| - Frag = Fragment | ||
| - Txn = Transaction | ||
| - Pkt = Packet |
Contributor
There was a problem hiding this comment.
I'd rather just remove abbreviations for "dup", "frag", "txn", and "packet"
mmcgee-jump
force-pushed
the
mmcgee/metricsalign
branch
from
8518d89 to
eb90e5e
Compare
ripatel-fd
reviewed
Jan 26, 2026
src/disco/metrics/metrics.xml
Outdated
|
|
||
| Abbreviations are both plural and singular depending on context, and do | ||
| not need to be made plural. For example TxnRx means "transactions | ||
| received" and should not be changed to TxnsRx. |
Contributor
There was a problem hiding this comment.
The metric should just be called transactions_received
ripatel-fd
reviewed
Jan 26, 2026
src/disco/metrics/metrics.xml
Outdated
| <counter name="InitialTokenLen" enum="QuicInitialTokenLen" summary="Number of Initial packets grouped by token length" /> | ||
| <counter name="TxnRx" enum="TpuRecvType" summary="Transactions received via TPU" /> | ||
|
|
||
| <counter name="TxnOverruns" summary="Transactions overrun before reassembly" /> |
Contributor
There was a problem hiding this comment.
There's an inconsistency, sometimes the last is a verb (overran) sometimes a noun (overruns)
mmcgee-jump
force-pushed
the
mmcgee/metricsalign
branch
from
eb90e5e to
e505a2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.