chore: support different tile names per client#259
Open
amliu-jumptrading wants to merge 1 commit intomainfrom
Open
chore: support different tile names per client#259amliu-jumptrading wants to merge 1 commit intomainfrom
amliu-jumptrading wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for client-specific tile naming so the UI can correctly display and index tiles whose names differ between Firedancer and Frankendancer.
Changes:
- Extend
tileTypeSchemato include both Firedancer and Frankendancer variants (resolv/resolh,execle/bank,poh/pohh). - Introduce a shared helper (
getClientSpecificTileNames) to map logical tiles to the correct tile type per client. - Update several performance/slot UI components to use the client-specific tile names when indexing tile counts and idle data.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils.ts | Adds getClientSpecificTileNames(client) helper used across UI to resolve tile type names per client. |
| src/api/entities.ts | Updates the Zod enum for TileType to include both client variants. |
| src/features/SlotDetails/DetailedSlotStats/PerformanceSection/CpuSparklines.tsx | Uses client-specific bank tile name for header and data lookup. |
| src/features/Overview/SlotPerformance/TransactionBarsCard/BarsChartContainer.tsx | Uses client-specific bank tile name to derive bank tile count. |
| src/features/Overview/SlotPerformance/TilesPerformance.tsx | Uses client-specific names for resolv/bank/poh cards and data lookups. |
| src/features/Overview/SlotPerformance/ComputeUnitsCard/index.tsx | Uses client-specific bank tile name to compute bank tile count. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firedancer_name | frankendancer_name
resolv | resolh (changed from resolv)
execle | bank (keeps old name)
poh | pohh (changed from poh)