Skip to content

chore: support different tile names per client#259

Open
amliu-jumptrading wants to merge 1 commit intomainfrom
amliu/franken-tiles
Open

chore: support different tile names per client#259
amliu-jumptrading wants to merge 1 commit intomainfrom
amliu/franken-tiles

Conversation

@amliu-jumptrading
Copy link
Collaborator

firedancer_name | frankendancer_name
resolv | resolh (changed from resolv)
execle | bank (keeps old name)
poh | pohh (changed from poh)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for client-specific tile naming so the UI can correctly display and index tiles whose names differ between Firedancer and Frankendancer.

Changes:

  • Extend tileTypeSchema to include both Firedancer and Frankendancer variants (resolv/resolh, execle/bank, poh/pohh).
  • Introduce a shared helper (getClientSpecificTileNames) to map logical tiles to the correct tile type per client.
  • Update several performance/slot UI components to use the client-specific tile names when indexing tile counts and idle data.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/utils.ts Adds getClientSpecificTileNames(client) helper used across UI to resolve tile type names per client.
src/api/entities.ts Updates the Zod enum for TileType to include both client variants.
src/features/SlotDetails/DetailedSlotStats/PerformanceSection/CpuSparklines.tsx Uses client-specific bank tile name for header and data lookup.
src/features/Overview/SlotPerformance/TransactionBarsCard/BarsChartContainer.tsx Uses client-specific bank tile name to derive bank tile count.
src/features/Overview/SlotPerformance/TilesPerformance.tsx Uses client-specific names for resolv/bank/poh cards and data lookups.
src/features/Overview/SlotPerformance/ComputeUnitsCard/index.tsx Uses client-specific bank tile name to compute bank tile count.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants