Skip to content

Conversation

@jrothfeder
Copy link
Contributor

@jrothfeder jrothfeder commented Dec 16, 2025

Description

New command that allows for a user to run mobile tests that are defined as yaml. Tests will be read from a test dir and run remotely. Filters can be supplied to specify which tests are run.

Scenarios Tested

Tested running mobile tests from the command line.

Sample Commands

firebase apptesting:mobile-execute --app=1:359214138129:android:423758dfdb494e05f002b0 --test-dir=mytests ./app/build/outputs/apk/alpha/debug/app-alpha-debug.apk

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jrothfeder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the initial infrastructure for an experimental Mobile App Testing Agent (MATA) feature. It modifies the test parsing logic to make target URIs optional, accommodating diverse testing scenarios, potentially including those for mobile applications. Additionally, it enhances the logging within the test file parsing utility to provide clearer insights into its operation.

Highlights

  • Experimental MATA Feature: Introduced a new public experiment named 'mata' which stands for Mobile App Testing Agent, laying the groundwork for mobile app testing capabilities.
  • New Mobile App Testing Command: Added a new command, 'apptesting-mobile-execute', which becomes available when the 'mata' experiment is enabled, indicating a dedicated entry point for mobile test execution.
  • Flexible Test URI Handling: The 'targetUri' parameter in 'parseTestFiles' and the 'startUri' property in the 'TestCase' interface have been made optional, allowing for test configurations that may not always require a specific URI.
  • Enhanced Test File Parsing Logging: Improved visibility into the test file parsing process by adding logger statements to track file reading, parsing, and the number of tests found.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new experimental feature, "mata", for mobile app testing. The changes make targetUri optional when parsing test files to support this new feature. While the changes are mostly correct, there are a few critical issues that need to be addressed. A logging statement in parseTestFiles.ts incorrectly logs entire file contents, which is a security and performance concern. There's also a potential null reference exception in src/commands/index.ts when initializing the new mata command. Additionally, there are some opportunities to improve type safety and logging verbosity.

@jrothfeder jrothfeder changed the title WIP New command that allows for a user to run mobile tests that are defined as yaml. Dec 16, 2025
jrothfeder and others added 2 commits December 16, 2025 13:57
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@jrothfeder jrothfeder requested a review from tagboola December 16, 2025 19:03
},
];

export const command = new Command("apptesting:mobile-execute <target>")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider putting this under the app distribution namespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We went back and forth on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants