Reorganizing Crashlytics MCP Tools #9594
Conversation
Summary of ChangesHello @maxl0rd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the Crashlytics MCP tools by streamlining report generation into a single, unified function and externalizing detailed instructions into comprehensive resource guides. This change aims to enhance the system's scalability, improve the user experience for various MCP clients, and provide more robust error handling and guidance for developers interacting with Crashlytics data. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a great refactoring of the Crashlytics MCP tools. Consolidating the report-fetching tools into a single crashlytics_get_report tool is a significant improvement, making it more extensible. Moving the large prompt content into separate guide resources is also an excellent change for modularity and maintainability. The error handling has been improved across the tools, providing more context to the agent. I've found a few minor issues, including some typos in user-facing text, a small bug in output formatting, and opportunities for code simplification. Overall, this is a high-quality change.
schnecle
force-pushed
the
ml_crashlytics_resources
branch
from
97e8d00 to
89c8cdd
Compare
maxl0rd
force-pushed
the
ml_crashlytics_resources
branch
2 times, most recently
from
a2a73f9 to
80e2475
Compare
visumickey
left a comment
visumickey
left a comment
There was a problem hiding this comment.
Thanks for the changes!
| filter: EventFilter, | ||
| pageSize = DEFAULT_PAGE_SIZE, | ||
| ): Promise<Report> { | ||
| if (!reportName) { |
There was a problem hiding this comment.
Is there a default reportName that might be applied??
There was a problem hiding this comment.
Everything I tried always passes a correct report name. Default or empty would be an error.
- Moving crashlytics prompt into guides - Consolidating the report tools into a single get_report tool - Fixing bug where additional prompt said report result was empty - Including request filters in report tool response - Improving error handling and leveraging guides - Ignore gemini environment dotfile
maxl0rd
force-pushed
the
ml_crashlytics_resources
branch
from
539dd4c to
3fcd9e8
Compare
3 participants
Description
crashlytics_get_*tools into a single toolcrashlytics_get_report. This will enable the set of supported reports to expand without adding additional tools.crashlytics:connectprompt to guide resources. This provides better support for the many MCP clients without support for prompts.