Skip to content

feat: email link sign in should have separate way to enable #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
russellwheatley wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: email link sign in should have separate way to enable #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e51b9eb
feat: email link sign in should have separate way to enable
russellwheatley Dec 16, 2025
70240d7
test: different provider appear in default Views
russellwheatley Dec 16, 2025
935e6af
chore: update strings
russellwheatley Dec 16, 2025
2c4de6f
chore: format
russellwheatley Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Services/AuthService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public final class AuthService {

private var currentMFAResolver: MultiFactorResolver?
private var listenerManager: AuthListenerManager?
private var emailSignInCallback: (() -> Void)?
private var emailLinkSignInCallback: (() -> Void)?
private var providers: [AuthProviderUI] = []

public let configuration: AuthConfiguration
Expand All @@ -139,7 +139,8 @@ public final class AuthService {
public var currentUser: User?
public var authenticationState: AuthenticationState = .unauthenticated
public var authenticationFlow: AuthenticationFlow = .signIn
public var emailSignInEnabled = false
public var emailPasswordSignInEnabled = false
public var emailLinkSignInEnabled = false
public private(set) var navigator = Navigator()

public var authView: AuthView? {
Expand All @@ -153,13 +154,13 @@ public final class AuthService {
public func renderButtons(spacing: CGFloat = 16) -> AnyView {
AnyView(
VStack(spacing: spacing) {
if emailSignInEnabled {
if emailLinkSignInEnabled {
AuthProviderButton(
label: string.signInWithEmailLinkViewTitle,
style: .email,
accessibilityId: "sign-in-with-email-link-button"
) {
if let callback = self.emailSignInCallback {
if let callback = self.emailLinkSignInCallback {
callback()
} else {
self.navigator.push(.emailLink)
Expand Down Expand Up @@ -345,17 +346,9 @@ public extension AuthService {
// MARK: - Email/Password Sign In

public extension AuthService {
/// Enable email sign-in with default behavior (navigates to email link view)
/// Enable email/password sign-in (EmailAuthView is shown directly in AuthPickerView)
func withEmailSignIn() -> AuthService {
return withEmailSignIn { [weak self] in
self?.navigator.push(.emailLink)
}
}

/// Enable email sign-in with custom callback
func withEmailSignIn(onTap: @escaping () -> Void) -> AuthService {
emailSignInEnabled = true
emailSignInCallback = onTap
emailPasswordSignInEnabled = true
return self
}

Expand Down Expand Up @@ -392,6 +385,20 @@ public extension AuthService {
// MARK: - Email Link Sign In

public extension AuthService {
/// Enable email link sign-in with default behavior (navigates to email link view)
func withEmailLinkSignIn() -> AuthService {
return withEmailLinkSignIn { [weak self] in
self?.navigator.push(.emailLink)
}
}

/// Enable email link sign-in with custom callback
func withEmailLinkSignIn(onTap: @escaping () -> Void) -> AuthService {
emailLinkSignInEnabled = true
emailLinkSignInCallback = onTap
return self
}

/// Send email link for sign-in or reauthentication
/// - Parameters:
/// - email: Email address to send link to
Expand Down
Loading