Skip to content

percent encode endpoint path #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexiglesias93 merged 3 commits into from
Feb 5, 2025
Merged

percent encode endpoint path #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0450439
percent encode endpoint path
jjnistico Feb 4, 2025
6818e00
chore: document changes
alexiglesias93 Feb 5, 2025
9bcd6c3
chore: added changeset
alexiglesias93 Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/polite-ladybugs-begin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'fireworkers': patch
---

fix: support document IDs that contain hashes
7 changes: 6 additions & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ export const get_firestore_endpoint = (
const allPaths = ['v1', 'projects', project_id, 'databases', '(default)', 'documents', ...paths];
const path = allPaths.join('/') + suffix;

const endpoint = new URL(path, FIRESTORE_ENDPOINT);
const endpoint = new URL(FIRESTORE_ENDPOINT);

// We assign the pathname after instanciating the URL to ensure any hashes are encoded as part of the patname.
// This is done to support use cases where users have hashes in their document IDs.
endpoint.pathname = path;

return endpoint;
};