fix: pagination buttons not working when instance is added to the list instead of the wrapper element#778
Merged
alexiglesias93 merged 1 commit intomasterfrom Jan 8, 2026
Merged
Conversation
…t instead of the wrapper element
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where pagination buttons don't work when the instance attribute is added to the collection list element instead of the wrapper element. The fix modifies the button click handler to check if the clicked button's wrapper matches the list's wrapper element, providing an alternative to the instance attribute check.
Key Changes:
- Enhanced instance matching logic to support both wrapper-based and instance-based identification
- Added early return for clarity when no pagination button is clicked
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/list/src/load/pagination.ts | Updated handlePaginationButtons to check wrapper element equality in addition to instance attribute matching |
| .changeset/upset-rules-smash.md | Added changeset entry documenting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens because the pagination buttons are not a direct child of the collection list elements, but the collection list wrapper elements.