Mixed v1 updates: Resolve already fixed v1 issues list#480
Open
robertkibet wants to merge 29 commits intomasterfrom
Open
Mixed v1 updates: Resolve already fixed v1 issues list#480robertkibet wants to merge 29 commits intomasterfrom
robertkibet wants to merge 29 commits intomasterfrom
Conversation
|
@robertkibet is attempting to deploy a commit to the Finsweet Team on Vercel. To accomplish this, @robertkibet needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
…re it stops at the right end value
Contributor
Author
|
@lggtz @alexiglesias93 This is an update to the bug when using |
- there seems to be an issue with webkit browsers tests, need to investigate
…hed refs to the git issue
Contributor
Author
|
@alexiglesias93 branch is ready |
eb502c1 to
a6d92ac
Compare
- v1 pull request: #511
Contributor
Author
|
Hello @alexiglesias93 this PR has been updated to latest. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes these issues list:
numbercount: the count is not stopped at the correct value #394cmsfilter: Filter search highlight breaking HTML of links and spans #390readtime: Use Intl.NumberFormat() constructor options to automatically convert numbers to units using a defined locale or default to browser's set locale. #384rangeslider: Floating point issues in some cases #360socialsharetoc: Table of Contents solution breaks with iOS 17 on both Safari and Chrome #477 into v2existing v1 PRs
init()#387Intl.NumberFormatto number helpers #388Where to test this:
numbercount: https://www.freelancerepublik.com/ you will need to do local override, the client homepage has a number counter, it should end at the correct value specified in the attributefs-numbercount-end="9062", right now it goes beyond upto 9071 which is incorrect. This has been fixed ✅cmsfilter: https://www.unloan.com.au/faqs you will need to do local override and addfs-cmsfilter-highlight="true"then test this out. Couple of issues with the highlight attribute regex matcher includes, if you search numbers like "0", currency like "$10", search strings that are also found in href tags like the word "privacy" you will notice the results shown have some issues, some donot highlight and some break the html and end up showing the actual html tags in the results string fromoriginalHTMLvalue. This has been fixed ✅rangeslidercan be tested here https://fs-attributes.webflow.io/rangeslider Resolved fully ✅readtimecan be tested here https://fs-attributes.webflow.io/readtime I updated the docs also to includefs-readtime-instanceandfs-readtime-localewhich are additional settings added to this attribute. Resolved fully ✅socialsharecan be tested here https://fs-attributes.webflow.io/socialshare-v2 I have updated the attributes values from using postfix -NUMBER so that it works with v2 update and also added thefs-socialshare-instanceattribute to the elements and contents