Skip to content

Mixed v1 updates: Resolve already fixed v1 issues list#480

Open
robertkibet wants to merge 29 commits intomasterfrom
mixed-v1-updates
Open

Mixed v1 updates: Resolve already fixed v1 issues list#480
robertkibet wants to merge 29 commits intomasterfrom
mixed-v1-updates

Conversation

@robertkibet
Copy link
Contributor

@robertkibet robertkibet commented Sep 28, 2023

closes these issues list:

existing v1 PRs

Where to test this:

  • numbercount: https://www.freelancerepublik.com/ you will need to do local override, the client homepage has a number counter, it should end at the correct value specified in the attribute fs-numbercount-end="9062", right now it goes beyond upto 9071 which is incorrect. This has been fixed ✅
  • cmsfilter: https://www.unloan.com.au/faqs you will need to do local override and add fs-cmsfilter-highlight="true" then test this out. Couple of issues with the highlight attribute regex matcher includes, if you search numbers like "0", currency like "$10", search strings that are also found in href tags like the word "privacy" you will notice the results shown have some issues, some donot highlight and some break the html and end up showing the actual html tags in the results string from originalHTML value. This has been fixed ✅
  • rangeslider can be tested here https://fs-attributes.webflow.io/rangeslider Resolved fully ✅
  • readtime can be tested here https://fs-attributes.webflow.io/readtime I updated the docs also to include fs-readtime-instance and fs-readtime-locale which are additional settings added to this attribute. Resolved fully ✅
  • socialshare can be tested here https://fs-attributes.webflow.io/socialshare-v2 I have updated the attributes values from using postfix -NUMBER so that it works with v2 update and also added the fs-socialshare-instance attribute to the elements and contents

@vercel
Copy link

vercel bot commented Sep 28, 2023

@robertkibet is attempting to deploy a commit to the Finsweet Team on Vercel.

To accomplish this, @robertkibet needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@robertkibet
Copy link
Contributor Author

@lggtz @alexiglesias93 This is an update to the bug when using fs-cmsfilter-highlight="true". Check the demo clip for the usecases covered https://www.loom.com/share/2441c277dfde419ea1ec11c8446477c8?sid=a5e7bbd5-3806-4f6d-a0b7-28090f86b905

@alexiglesias93 alexiglesias93 added this to the 2024 Q1 milestone Jan 16, 2024
@robertkibet robertkibet changed the base branch from v2 to v2-tests January 17, 2024 08:57
@robertkibet robertkibet changed the base branch from v2-tests to v2 January 18, 2024 18:23
@robertkibet
Copy link
Contributor Author

@alexiglesias93 branch is ready

@robertkibet robertkibet changed the base branch from v2 to v2-tests January 19, 2024 10:15
@robertkibet robertkibet changed the base branch from v2-tests to v2 January 19, 2024 10:17
Base automatically changed from v2 to master March 21, 2024 18:41
@robertkibet
Copy link
Contributor Author

Hello @alexiglesias93 this PR has been updated to latest. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reflect all open v1 PR updates in v2

3 participants