Conversation
This reverts commit abb6a54.
|
@michaelgatuma is attempting to deploy a commit to the Finsweet Team on Vercel. To accomplish this, @michaelgatuma needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
robertkibet
left a comment
robertkibet
left a comment
There was a problem hiding this comment.
Great stuff 🚀
Just some questions and a possible code improvement
| name: 'Button', | ||
| description: 'A button to open WhatsApp', | ||
| allowedTypes: ['Link'], | ||
| settings: [SCHEMA_SETTINGS.phone, SCHEMA_SETTINGS.message], |
There was a problem hiding this comment.
should we have another element without the settings? for dynamic elements this button is just a wrapper and has no fs-whatsapp-phone or fs-whatsapp-message
🤔
There was a problem hiding this comment.
Maybe @alexiglesias93 can advise on this.
If user accidentally adds a number like ++1233434, this regex will not remove the extra plus. Therefore, remove everything that is not a number from the phone number, then append a '+' sign
|
@michaelgatuma just one minor thing I noticed: 
When testing this locally, the resultant whatsapp message seems to add some white spaces, as shown by the multiple 
<a
fs-whatsapp-element="button"
href="https://wa.me/+254725353920?text=%0A++++++++++++++++++++++++Wassup%2C+I%27m+interested+in+a+quote%21%0A++++++++++++++++++++++++%0A++++++++++++++++++++++++Are+you+interested%3F+visit+mywebsite.com%0A++++++++++++++++++++++"
class="button w-inline-block"
target="_blank"
><img
src="https://assets.website-files.com/64af195b0306c12d295ea1dc/64af1bbcf71d8da4ffa20b98_whatsapp-color-svgrepo-com.svg"
loading="lazy"
alt=""
class="icon-1x1-medium"
/>
<div>Total Body Car Repair</div>
<div>Contact us on WhatApp</div>
<div fs-whatsapp-element="message" class="hide">
Wassup, I'm interested in a quote!
<br />
Are you interested? visit mywebsite.com
</div>
<div fs-whatsapp-element="phone" class="hide">+254725353920</div>
</a> |
alexiglesias93
dismissed
robertkibet’s stale review
The base branch was changed.
|
An owner of the Finsweet Team on Vercel declined @michaelgatuma's request to join. In order for their commit to be deployed, @michaelgatuma must push and request access again. |
4 participants
No description provided.