Skip to content

feat: allow spaces in union expressions for better readability#140

Merged
ssaarela merged 5 commits intomasterfrom
f/parser-ignore-ws
Sep 15, 2025
Merged

feat: allow spaces in union expressions for better readability#140
ssaarela merged 5 commits intomasterfrom
f/parser-ignore-ws

Conversation

@ssaarela
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f36eb0c) to head (b50edf7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #140    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           20        20            
  Lines         4427      3474   -953     
  Branches       704       704            
==========================================
- Hits          4427      3474   -953     
Files with missing lines Coverage Δ
packages/path-parser/src/matcherGrammar.ts 100.00% <100.00%> (ø)
packages/path-parser/src/pathGrammar.ts 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Samppa Saarela <samppa.saarela@iki.fi>
Signed-off-by: Samppa Saarela <samppa.saarela@iki.fi>
BREAKING_CHANGE

Signed-off-by: Samppa Saarela <samppa.saarela@iki.fi>
@ssaarela ssaarela marked this pull request as draft September 12, 2025 12:09
Signed-off-by: Samppa Saarela <samppa.saarela@iki.fi>
@ssaarela ssaarela changed the title feat: Union PathMatcher ignores whitespace around commas feat: allow spaces in union expressions for better readability Sep 12, 2025
@ssaarela ssaarela marked this pull request as ready for review September 12, 2025 15:05
Signed-off-by: Samppa Saarela <samppa.saarela@iki.fi>
Copy link
Contributor

@karlkeskyla karlkeskyla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - absolutely neat as always! 🎉

@ssaarela ssaarela merged commit abe1d9f into master Sep 15, 2025
7 checks passed
@ssaarela ssaarela deleted the f/parser-ignore-ws branch September 15, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants