remove dependency on plugin.program.autocomlplete#3
Open
scott967 wants to merge 1 commit intofinkleandeinhorn:masterfrom
Open
remove dependency on plugin.program.autocomlplete#3scott967 wants to merge 1 commit intofinkleandeinhorn:masterfrom
scott967 wants to merge 1 commit intofinkleandeinhorn:masterfrom
Conversation
|
Sad, that nobody answered for this PR over 2 years. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 2.1.1 of this script introduces an implied dependency on plugin.program.autocompletion
This results in it not being backwards compatible when script.module.autocompletion is used in other scripts as a dependency -- it creates an exception in Kodi when plugin.program.autocompletion is not installed.
This PR restores compatibility by wrapping the calls to plugin.program.autocompletion in a try/except block. If plugin.program.autocompletion is not installed/enabled the except will fall back to running as it did in ver 2.0.6 and prior.
Tested in an addon which uses script.module.kutils which in turn has dependency on scritp.module.autocompletion.