Skip to content

Update README.md#2

Open
leshems wants to merge 1 commit intomasterfrom
leshems-patch-3
Open

Update README.md#2
leshems wants to merge 1 commit intomasterfrom
leshems-patch-3

Conversation

@leshems
Copy link

@leshems leshems commented Apr 18, 2023

Thanks for the PR!

To better assist you, please select the type of PR you want to create.

Click the "Preview" tab above, and click on the link for the PR type:

@finehq finehq deleted a comment from fine-ai bot Apr 18, 2023
@finehq finehq deleted a comment from fine-ai bot Apr 18, 2023
@fine-ai
Copy link

fine-ai bot commented Apr 18, 2023

Great job fulfilling most of the requirements! Please consider requirements that might not have been fulfilled:

✅ 1. createStore.js: Store enhancer added to accept Map and Set data types.
✅ 2. combineReducers.js: Reducer added to handle Map and Set data types.
✅ 3. bindActionCreators.js: Action creator added to dispatch action to the reducer.
✅ 4. applyMiddleware.js: Middleware compatibility ensured with Map and Set data types.
✅ 5. compose.js: Composed functions compatibility ensured with Map and Set data types.
✅ 6. utils/actionTypes.js: Action types compatibility ensured with Map and Set data types.
✅ 7. types/store.js: Store compatibility ensured with Map and Set data types.
❗️ 8. types/reducers.js: Please double check this file, as it seems the compatibility with Map and Set data types might not be fully ensured.

Overall, your changes look solid, and you have addressed most of the requirements. Please take a look at requirement 8, and make sure that the reducers in types/reducers.js are compatible with the Map and Set data types. Once that is addressed, this pull request should be good to go!

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant