Feature/add period columns to queries#29
Open
LavenHook wants to merge 3 commits intofindulov:masterfrom
Open
Conversation
added 3 commits
February 1, 2021 08:38
Added ForAll query to get all temporal entities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR may be a little premature. I have a need to be able to see the period columns when querying the complete history of an entity. Since the period columns are hard-coded* in this project, it seems fitting that the temporal table queries include the columns.
*I think the period columns should be a little more flexible in the long run - which is something that I may consider working on myself, if/when I get time. This would also go hand-in-hand with issue #27 - add functionality to specify temporal table name and schema and #2 - Configure temporal column names.
For now, I offer this PR, which is enough to satisfy my simple use cases.
Thanks,
Isaac